Commit 72b4c6a5 authored by 技术部-任文超's avatar 技术部-任文超

删除InnerController.saveUserDetail的id参数,理由:sdk的UserSdkServiceImpl.modifyUserDeta...

删除InnerController.saveUserDetail的id参数,理由:sdk的UserSdkServiceImpl.modifyUserDetail方法与UserSdkServiceImpl.saveUserDetail方法功能重合,仅仅多一个id参数,且处理方式会出现给Long传"null"的坑,并且用户中心的UserDetailService中不存在按照id查询实例的方法,故此判断该参数最多只属于函谷关(已下线)场景,新用户中心已不支持id方式
parent c3c6c42a
...@@ -235,12 +235,13 @@ public class InnerController implements IBaseController { ...@@ -235,12 +235,13 @@ public class InnerController implements IBaseController {
/** /**
* 保存用户详细信息 * 保存用户详细信息
* 适用于:创建 或 修改
*/ */
@LogHttpCaller @LogHttpCaller
@RequestMapping("/user_detail/save") @RequestMapping("/user_detail/save")
public JsonResult saveUserDetail(Long userId, String phoneNo, String name, String idNo, public JsonResult saveUserDetail(Long userId, String phoneNo, String name, String idNo,
String email, String qq, Long id) { String email, String qq) {
LOGGER.info("保存用户详细信息,phoneNo:{},userId;{},name:{},idNo:{},email;{},qq;{}", phoneNo, userId, name, idNo, email, qq); LOGGER.info("保存用户详细信息,[saveUserDetail] userId:{},phoneNo:{},name:{},idNo:{},email:{},qq:{}", userId, phoneNo, name, idNo, email, qq);
//参数验证 //参数验证
if (userId == null || userId == 0L) { if (userId == null || userId == 0L) {
return JsonResult.buildErrorStateResult("用户id为空.", null); return JsonResult.buildErrorStateResult("用户id为空.", null);
...@@ -262,7 +263,6 @@ public class InnerController implements IBaseController { ...@@ -262,7 +263,6 @@ public class InnerController implements IBaseController {
info = idCardService.getIdCardInfo(idNo); info = idCardService.getIdCardInfo(idNo);
} catch (ParseException ex) { } catch (ParseException ex) {
LOGGER.error("用户身份证号错误, idNo: {}", idNo); LOGGER.error("用户身份证号错误, idNo: {}", idNo);
return JsonResult.buildErrorStateResult("身份证号码错误", null);
} }
if (Objects.isNull(info) || !info.isValid()) { if (Objects.isNull(info) || !info.isValid()) {
return JsonResult.buildErrorStateResult("身份证号码错误", null); return JsonResult.buildErrorStateResult("身份证号码错误", null);
...@@ -288,10 +288,6 @@ public class InnerController implements IBaseController { ...@@ -288,10 +288,6 @@ public class InnerController implements IBaseController {
if(Objects.isNull(userDetail)){ if(Objects.isNull(userDetail)){
userDetail = new UserDetail(); userDetail = new UserDetail();
userDetail.setCreatedAt(now); userDetail.setCreatedAt(now);
// 这三行本不应出现,因为Service层没有提供按id查询UserDetail的方法,保留是为了兼容未知的旧有更新操作
if (id != null && id > 0) {
userDetail.setId(id);
}
} }
userDetail.setUserId(userId); userDetail.setUserId(userId);
userDetail.setName(name); userDetail.setName(name);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment