sonar修复1

src/main/java/cn/quantgroup/cashloanflowboss/api/oneclickdata/service/impl/RepaymentPlatServiceImpl.java

@@ -128,8 +128,8 @@ public class RepaymentPlatServiceImpl implements RepaymentPlatService {
         log.info("打印一下result={}",result);
         String businessCode=result.get("businessCode").toString().trim();
         if(!Objects.isNull(result) && businessCode.equals(ResposeResultEnum.BUSINESSCODE.getDesc())){
-            if(StringUtils.isNotEmpty(result.get("data").toString().trim())){
-                String data=result.get("data").toString().trim();
+           String data=result.get("data").toString().trim();
+            if(StringUtils.isNotEmpty(data)){
                 repaymentToken=result.get("data").toString().trim().split("//?")[2].split("&")[0].split("=")[1];
             }
 
@@ -151,8 +151,8 @@ public class RepaymentPlatServiceImpl implements RepaymentPlatService {
         JSONObject result= HttpRequest.doGetReturnResponseJson(url, null, header);
         String businessCode=result.get("businessCode").toString().trim();
         if(!Objects.isNull(result) && businessCode.equals(ResposeResultEnum.BUSINESSCODE.getDesc())){
-            if (!Objects.isNull(result.get("data"))){
-                JSONObject data=(JSONObject) result.get("data");
+            JSONObject data=(JSONObject) result.get("data");
+            if (!Objects.isNull(data)){
                 log.info("获取卡信息的reslut={}",result);
                boolean isRight=isCardInfo(data, oneClickData.getId());
                 //是继续调用金额还是重新绑卡确认
@@ -212,19 +212,19 @@ public class RepaymentPlatServiceImpl implements RepaymentPlatService {
 
     public boolean isCardInfo(JSONObject result,Long id){
         JSONObject dataObject=result;
-
-        if(!Objects.isNull(dataObject.get("cardList"))){
-            JSONArray cardList=(JSONArray) dataObject.get("cardList");
+        JSONArray cardList=(JSONArray) dataObject.get("cardList");
+        if(!Objects.isNull(cardList)){
             JSONObject cardListObject=(JSONObject)cardList.get(0);
             String  payApproach=cardListObject.get("payApproach").toString().trim();
             String preservePhoneNo=cardListObject.get("preservePhoneNo").toString().trim();
             String cardId= cardListObject.get("id").toString().trim();
             String  cardBindInfoId ="";
             log.info("获取当前的cardListObject={}",cardListObject);
-
-            if(cardListObject.toString().contains("cardBindInfoId")) {
+         String cardBindInfoIdKey="cardBindInfoId";
+            if(cardListObject.toString().contains(cardBindInfoIdKey)) {
                 cardBindInfoId=cardListObject.get("cardBindInfoId").toString().trim();
-                if(cardBindInfoId.equals("0")){
+               String getValue="0";
+                if(cardBindInfoId.equals(getValue)){
                     //修改卡信息保存到表中,并且当前的cardBindInfoId没有值
                     updateCardInfo(payApproach,preservePhoneNo,cardId,cardBindInfoId,id);
                     return false;