Skip to content

H
holmes
Commit d4b5d7c8 authored by 黎博's avatar 黎博
Browse files
Options

优化

parent 4530bbb7
Show whitespace changes
Inline Side-by-side
Showing with 16 additions and 18 deletions
src/main/java/cn/qg/holmes/service/effect/impl/DatabaseSyncServiceImpl.java
View file @ d4b5d7c8
...@@ -96,6 +96,7 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService { ...@@ -96,6 +96,7 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService {
while (dbResultSet.next()) { while (dbResultSet.next()) {
dbRedisValue = dbResultSet.getString(2); dbRedisValue = dbResultSet.getString(2);
} }
dbResultSet.close();
// 设置建库语句的redis值 // 设置建库语句的redis值
redisUtils.set(dbRedisKey, dbRedisValue, 86400); redisUtils.set(dbRedisKey, dbRedisValue, 86400);
} }
...@@ -123,6 +124,8 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService { ...@@ -123,6 +124,8 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService {
while (pResultSet.next()) { while (pResultSet.next()) {
createTableRedisValue = pResultSet.getString(2); createTableRedisValue = pResultSet.getString(2);
} }
pResultSet.close();
redisUtils.set(createTableKey, createTableRedisValue, 86400); redisUtils.set(createTableKey, createTableRedisValue, 86400);
createTableRedisValue = ""; createTableRedisValue = "";
} }
...@@ -139,7 +142,8 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService { ...@@ -139,7 +142,8 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService {
columnNameList.add(columnName); columnNameList.add(columnName);
columnTypeList.add(columnType); columnTypeList.add(columnType);
} }
// String columnArrayStr = null; columnResultSet.close();
StringBuilder columnArrayStr = new StringBuilder(); StringBuilder columnArrayStr = new StringBuilder();
for (String column : columnNameList) { for (String column : columnNameList) {
if (columnArrayStr.length() == 0) { if (columnArrayStr.length() == 0) {
...@@ -147,14 +151,8 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService { ...@@ -147,14 +151,8 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService {
} else { } else {
columnArrayStr.append(",`").append(column).append("`"); columnArrayStr.append(",`").append(column).append("`");
} }
// if (null == columnArrayStr) {
// columnArrayStr = "`" + column + "`";
// } else {
// columnArrayStr = columnArrayStr + "," + "`" + column + "`";
// }
} }
// String selectSQL = String.format("select %s from %s", columnArrayStr, tableName);
preparedStatement = connection.prepareStatement("select " + columnArrayStr + " from " + tableName); preparedStatement = connection.prepareStatement("select " + columnArrayStr + " from " + tableName);
ResultSet selectResultSet = preparedStatement.executeQuery(); ResultSet selectResultSet = preparedStatement.executeQuery();
StringBuilder insertSql = new StringBuilder(); StringBuilder insertSql = new StringBuilder();
...@@ -171,15 +169,15 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService { ...@@ -171,15 +169,15 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService {
.append(rowValues) .append(rowValues)
.append(");"); .append(");");
insertSql = replaceAll(insertSql, "\n", "<br/>"); insertSql = replaceAll(insertSql, "\n", "<br/>");
// insertSql = insertSql.replaceAll("\n", "<br/>");
// insertSql = insertSql + "\n";
insertSql.append("\n"); insertSql.append("\n");
insertRedisValue.append(insertSql); insertRedisValue.append(insertSql);
// 清空insertSql // 清空insertSql
insertSql.delete(0, insertSql.length()); insertSql.delete(0, insertSql.length());
} }
selectResultSet.close();
columnNameList.clear(); columnNameList.clear();
columnTypeList.clear(); columnTypeList.clear();
redisUtils.set(insertTableKey, insertRedisValue.toString(), 86400); redisUtils.set(insertTableKey, insertRedisValue.toString(), 86400);
long endTime = System.currentTimeMillis(); long endTime = System.currentTimeMillis();
log.info("{}表数据获取完成，共花费{}秒", tableName, (endTime - startTime) / 1000); log.info("{}表数据获取完成，共花费{}秒", tableName, (endTime - startTime) / 1000);
...@@ -187,6 +185,7 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService { ...@@ -187,6 +185,7 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService {
insertRedisValue.delete(0, insertRedisValue.length()); insertRedisValue.delete(0, insertRedisValue.length());
} }
} }
tableResultSet.close();
redisUtils.set(tableListKey, tableListStr.toString(), 86400); redisUtils.set(tableListKey, tableListStr.toString(), 86400);
} catch (Exception e) { } catch (Exception e) {
e.printStackTrace(); e.printStackTrace();
...@@ -271,6 +270,7 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService { ...@@ -271,6 +270,7 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService {
while (dbResultSet.next()) { while (dbResultSet.next()) {
dbRedisValue = dbResultSet.getString(2); dbRedisValue = dbResultSet.getString(2);
} }
dbResultSet.close();
// 设置建库语句的redis值 // 设置建库语句的redis值
redisUtils.set(dbRedisKey, dbRedisValue, 86400); redisUtils.set(dbRedisKey, dbRedisValue, 86400);
} }
...@@ -282,6 +282,7 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService { ...@@ -282,6 +282,7 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService {
while (resultSet.next()) { while (resultSet.next()) {
redisUtils.set(tableCreateKey, resultSet.getString(2), 600); redisUtils.set(tableCreateKey, resultSet.getString(2), 600);
} }
resultSet.close();
} }
if (!redisUtils.hasKey(tableInsertKey)) { if (!redisUtils.hasKey(tableInsertKey)) {
...@@ -296,14 +297,10 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService { ...@@ -296,14 +297,10 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService {
columnNameList.add(columnName); columnNameList.add(columnName);
columnTypeList.add(columnType);; columnTypeList.add(columnType);;
} }
// String columnArrayStr = null; columnResultSet.close();
StringBuilder columnArrayStr = new StringBuilder(); StringBuilder columnArrayStr = new StringBuilder();
for (String column : columnNameList) { for (String column : columnNameList) {
// if (null == columnArrayStr) {
// columnArrayStr = "`" + column + "`";
// } else {
// columnArrayStr = columnArrayStr + "," + "`" + column + "`";
// }
if (columnArrayStr.length() == 0) { if (columnArrayStr.length() == 0) {
columnArrayStr.append("`").append(column).append("`"); columnArrayStr.append("`").append(column).append("`");
} else { } else {
...@@ -334,6 +331,8 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService { ...@@ -334,6 +331,8 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService {
insertRedisValue.append(insertSql); insertRedisValue.append(insertSql);
insertSql.delete(0, insertSql.length()); insertSql.delete(0, insertSql.length());
} }
selectResultSet.close();
redisUtils.set(tableInsertKey, insertRedisValue.toString(), 600); redisUtils.set(tableInsertKey, insertRedisValue.toString(), 600);
insertRedisValue.delete(0, insertRedisValue.length()); insertRedisValue.delete(0, insertRedisValue.length());
} }
...@@ -386,9 +385,6 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService { ...@@ -386,9 +385,6 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService {
try { try {
Class.forName(driver); Class.forName(driver);
// connection = DriverManager.getConnection(url, username, password);
// connection.setAutoCommit(false);
// DatabaseMetaData databaseMetaData = connection.getMetaData();
String createDbSql = redisUtils.get(createDbKey).toString(); String createDbSql = redisUtils.get(createDbKey).toString();
String createTableSql = redisUtils.get(tableCreateKey).toString(); String createTableSql = redisUtils.get(tableCreateKey).toString();
...@@ -422,6 +418,7 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService { ...@@ -422,6 +418,7 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService {
columnNameList.add(columnName); columnNameList.add(columnName);
columnTypeList.add(columnType);; columnTypeList.add(columnType);;
} }
columnResultSet.close();
StringBuilder columnArrayStr = new StringBuilder(); StringBuilder columnArrayStr = new StringBuilder();
for (String column : columnNameList) { for (String column : columnNameList) {
...@@ -452,6 +449,7 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService { ...@@ -452,6 +449,7 @@ public class DatabaseSyncServiceImpl implements DatabaseSyncService {
backupDataSql.append(insertSql); backupDataSql.append(insertSql);
insertSql.delete(0, insertSql.length()); insertSql.delete(0, insertSql.length());
} }
selectResultSet.close();
// 如果表存在，则首先删除表 // 如果表存在，则首先删除表
log.info("表数据备份完成，删除环境中的{}.{}表", dbName, tableName); log.info("表数据备份完成，删除环境中的{}.{}表", dbName, tableName);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment