抽取代码

src/main/java/cn/quantgroup/xyqb/service/auth/impl/UserAuthorizedServiceImpl.java

@@ -46,30 +46,38 @@ public class UserAuthorizedServiceImpl implements IUserAuthorizedService {
 
     @Override
     public String createUserAuthorized(UserAuthorizedParam userAuthorizedParam) {
-        if (null == userAuthorizedParam) {
-            return Constants.CREATE_USER_AUTHORIZED_FAIL;
-        }
-        String name = userAuthorizedParam.getName();
-        Long userId = userAuthorizedParam.getUserId();
-        String authPattern = userAuthorizedParam.getAuthPattern();
-        String idNo = userAuthorizedParam.getIdNo();
         try {
-            if (StringUtils.isBlank(name) || userId == null || userId == 0L
-                    || StringUtils.isBlank(authPattern) || !iIdCardService.isIdCardValid(idNo)) {
+            if (checkUserAuthorizedParam(userAuthorizedParam)) {
                 return Constants.CREATE_USER_AUTHORIZED_FAIL;
             }
         } catch (Exception e) {
             LOGGER.error("[createUserAuthorized]参数有误:{}", e);
             return Constants.CREATE_USER_AUTHORIZED_FAIL;
         }
-        AuthPattern authPatternEnum = AuthPattern.valueOf(authPattern);
+        return saveUserAuthorized(userAuthorizedParam);
+    }
+
+    private Boolean checkUserAuthorizedParam(UserAuthorizedParam userAuthorizedParam) throws Exception {
+        if (null == userAuthorizedParam) {
+            return Boolean.TRUE;
+        }
+        String name = userAuthorizedParam.getName();
+        Long userId = userAuthorizedParam.getUserId();
+        String authPattern = userAuthorizedParam.getAuthPattern();
+        String idNo = userAuthorizedParam.getIdNo();
+        return (StringUtils.isBlank(name) || userId == null || userId == 0L
+                || StringUtils.isBlank(authPattern) || !iIdCardService.isIdCardValid(idNo));
+    }
+
+    private String saveUserAuthorized(UserAuthorizedParam userAuthorizedParam) {
+        AuthPattern authPatternEnum = AuthPattern.valueOf(userAuthorizedParam.getAuthPattern());
 
         UserAuthorized userAuthorized = new UserAuthorized();
         userAuthorized.setAuthPattern(authPatternEnum);
         userAuthorized.setAvailable(Boolean.TRUE);
-        userAuthorized.setName(name);
-        userAuthorized.setIdNo(idNo);
-        userAuthorized.setUserId(userId);
+        userAuthorized.setName(userAuthorizedParam.getName());
+        userAuthorized.setIdNo(userAuthorizedParam.getIdNo());
+        userAuthorized.setUserId(userAuthorizedParam.getUserId());
         Timestamp now = new Timestamp(System.currentTimeMillis());
         userAuthorized.setCreatedAt(now);
         userAuthorized.setUpdatedAt(now);